 |
|
 |
|
- Readme First! -
Read and follow the rules, otherwise your posts will be closed |
|
|
|
|
|
There are currently, 572 guest(s) and 0 member(s) that are online.
You are Anonymous user. You can register for free by clicking here |
|
|
|
|
|
Regarding Registered Users still restricted bug 7.0 |
|
 XEULAS writes "I've always felt that when doing a 'fix', one should change as little as possible of someone elses code... (because continuous changes mean at some point it could possibly no longer resemble the original code, and if the author updates his code with the fix, s/he would probably only change the part that needs fixing- which means if you changed more than the author, you would then have a derivitive that does not match the authors code, and any newer releases could eventually screw you up).
What I'm getting at, is that there is no need to change this code as much as has been recently stated in a post by FB. The ONLY change that is actually needed is the addition of the equal sign, to wit:
You need to edit mainfile.php and go to the line 289 where you can find the following text:
if ($points > 0 AND $points >= $row[points] || $mod_group == 0) {
Just change it to:
if ($points >= 0 AND $points >= $row[points] || $mod_group == 0) {"
|
|
Posted on Wednesday, December 17 @ 11:48:06 CET by Zhen-Xjell |
|
|
|
|
| |
|
|
| | The comments are owned by the poster. We aren't responsible for their content. |
| | | | |
| No Comments Allowed for Anonymous, please register | | | | |
Re: Regarding Registered Users still restricted bug 7.0 (Score: 1)
by MrFluffy on Wednesday, December 17 @ 16:37:24 CET
(User Info | Send a Message) http://www.conrads-berlin.de | Now it's my turn to say "We meet again, buahaha.." :)
As i already wrote in the original thread of this 'fix', the $grp variable isn't my invention, it's defined in the original code in the line above... for what. As far as i know it's chatserv who caught that, and because i use chatserv's secfixes, it's included in my fixed line of code.
The brackets i also admitted are in no way necessary... other than in trying to make some of the logic behind this line a little more clear for those insistently believing in the modules.php workaround ;).
cu,
MrFluffy |
| | | | |
Re: Regarding Registered Users still restricted bug 7.0 (Score: 1)
by XEULAS (MotherPlucker@KentuckyFriedChicken.com) on Wednesday, December 17 @ 17:33:03 CET
(User Info | Send a Message) http://www.SiteLance.com | | NOTE: That last line looks like it has a double-quote mark at the end (due to the news module 'quoting' me), and it does NOT belong in the actual code. |
| | | | |
Re: Regarding Registered Users still restricted bug 7.0 (Score: 1)
by chatserv on Friday, December 19 @ 00:14:07 CET
(User Info | Send a Message) http://nukeresources.com | | Both of you have already covered the topic well enough so all i will add is that the reasoning behind the $grp variable becomes evident if you take a closer look at the code involved, the $row[points] value belongs to one of the earlier sql queries in the section of code, $grp on the other hand is located right before the line mentioned in the fix, logic tells us that it was meant to be used somewhere but it was not, no point in converting $row[points] into $grp if it will not be used, the main idea of this altered variable is to differentiate it from the previous points value. |
| | | | | |
|
